[Bug] [dinky-client] Fix the bug in mounting the log configuration file in Flink. #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct get methods in enum fields.
github-actions
bot
requested review from
aiwenmo,
gaoyan1998,
zackyoungh and
Zzm0809
|
Okay. Welcome to fix this problem for other Flink versions of Dinky. thx |
Jam804
force-pushed
the
k8s_conf_mount
branch
from
b0750f3 to
5485cda
Compare
你好，我已经把之前在flink 1.18的修复和优化应用到了其他flink版本上， 请review |
@gaoyan1998 PTAL |
每个版本我都验证过, 主要改动在这两处 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在flink源码中关于k8s的conf文件只挂载了两个，其他log文件没有挂载导致flink on k8s有些功能使用时报没有log配置文件的错，这个问题我已经向flink官方提交代码修复 ，在flink2.0之后的版本应该不会有问题，此次修复dinky1.14和1.18版本的这个问题， 如果review没问题，我接下来将会用相同的思路修复dinky其他flink版本的这个问题