Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL compatibility issue for AWS Athena #395

Conversation

popcornylu
Copy link
Contributor

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link

linear bot commented Aug 5, 2024

Signed-off-by: popcorny <[email protected]>
@popcornylu popcornylu force-pushed the feature/drc-425-fix-query-diff-value-diff-top-k-histogram-query-issue-for branch from 260fe03 to 2f15c29 Compare August 5, 2024 09:39
@popcornylu
Copy link
Contributor Author

I have solved the topk and histogram

For profile diff and value diff, it requires to copy the macros/recce_athena.sql to you macors folder.

@popcornylu popcornylu merged commit 2156c77 into main Aug 5, 2024
3 checks passed
@popcornylu popcornylu deleted the feature/drc-425-fix-query-diff-value-diff-top-k-histogram-query-issue-for branch August 5, 2024 09:46
@popcornylu
Copy link
Contributor Author

Partially fix #392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant