Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Disable static file cache when access recce homepage #573

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

wcchang1115
Copy link
Collaborator

@wcchang1115 wcchang1115 commented Jan 9, 2025

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature

What this PR does / why we need it:

  • Disable cache when access static file of the home page
  • use no-store to skip If-None-Match and If-Modified-Since check

Which issue(s) this PR fixes:
DRC-995

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Wei-Chun, Chang <[email protected]>
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
recce/server.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
recce/server.py 52.45% <0.00%> (ø)

... and 6 files with indirect coverage changes

@wcchang1115 wcchang1115 marked this pull request as ready for review January 10, 2025 04:41
@wcchang1115 wcchang1115 merged commit 3535f34 into main Jan 10, 2025
10 checks passed
@wcchang1115 wcchang1115 deleted the feature/drc-995-browsing-recce-server-failed branch January 10, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants