Broker integration test #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've created a a Docker Container file which should start 3 containers: - mysql - rabbitMQ - worker I've reconfigured Travis in order to start this docker container before the build. I've added some simple integration test for the broker: datavault-broker/src/test/java/org/datavaultplatform/broker/services/VaultsServiceIT.java The test is creating one Vault and checking it has been added to the database using the VaultService.
Made a few cahnges to the Dockerfile, supervisor config and docker-compose file.
RabbitMQ contaienr seems to not be ready when the test are running.
In order to make sure that the workers start with RabbitMQ ready, I've added a script checking that service is running. ssue #396 (RSS022-74) - Wait for containerus# new file: docker/wait-for-rabbitmq.sh
gmh04
approved these changes
Nov 24, 2017
|
Closing because the build on Travis actually failed. I've fixed the problem as part of another issue #398 which also contain these code changes. I'll create a new PR with both CI and integration tests changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configured Maven to run integration Test for the Broker
Integration test require Docker containers running the MySql DB, RabbitMQ and the Workers.
Travis has been setup to start the requires Docker containers
Created a very basic integration Test: VaultsServiceIT.java
to give an example of what needs to be done.