Defer code loading when active record is properly loaded #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is well known issue. We should prefer to code that reference active record only when it's already lazy loaded. It can break other gems initializing process Related: - rails/rails#46567 - paper-trail-gem/paper_trail@fc6c5f6 (inspiration) - thoughtbot/factory_bot_rails#432 Fix: DatabaseCleaner#89
casperisfine
added a commit
to casperisfine/database_cleaner-active_record
that referenced
this pull request
Nov 23, 2023
Doing this cause a slew of problems with Rails loading process, causing some configurations not to be applied, etc. Fix: DatabaseCleaner#89 Fix: DatabaseCleaner#90
|
Closing in favor of #91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is well known issue. We should prefer to load code that reference active record only when it's AR is already loaded.
It can break other gems initializing process like thoughtbot/factory_bot_rails#432
Related:
Fix: #89