-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separated linalg module into a package #67
base: master
Are you sure you want to change the base?
Conversation
|
what is you objection besides the possibility of introducing bugs, even though I did not change any code? |
I am not against it, just considering options. E.g. this change would break backwards compatibility e.g., this change breaks with older DMD versions. But I don't see a general advantage (except maintainability). |
There are no obvious drawbacks in accepting this pull request, right? |
I still don't see a benefit in splitting it (yet). If there will be a split in the future it will also involve changing more files, I really don't like that ext module etc. |
what do u mean by "ext module"? |
gl3n.ext |
Ah, that gl3n.ext entered the discussion pretty randomly. Thought it was something related to these changes, was wondering why I couldn't find it in the changes for this PR. Anyway.. what is the plan/vision then? |
This change would be great. From my personal XP:
I can do it, just need the green light. Also DServer under VisualSC gives tons of warnings, it would be nice to have clean cut modules to work those warnings incrementally. |
i have simply split up the module, no other changes for now.
what do you think ?