Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrapped function with C++14 and repackaged with VS2022 #3

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

GsoyG
Copy link

@GsoyG GsoyG commented Nov 25, 2023

  • Encapsulate the main functions into the DHCPServer class and the message structure into the DHCPMessage class.
  • Split the output into main.cpp and replace the original error output with exceptions.
  • Replaced the original macro definition with static member functions and constant expressions.
  • Put the else judgment of if in front to simplify the if hierarchy.
  • Removed LocalFree check.

@DavidAnson
Copy link
Owner

This is very interesting, but I'm not in a place to review or test changes to this project. Sorry! Looking at how much you've invested, maybe you would like to maintain a fork of the project?

@GsoyG
Copy link
Author

GsoyG commented Nov 27, 2023

Thank you very much for your reply.
I am a C++ beginner, this is my first time creating a pull request to a public repository, and I am not very familiar with these operations.
I needed to use the DHCP function in one of my gadgets, so I found this repository. But these codes seemed to be written in C style, so I modified them in C++ style according to my ideas.
I thought this code might be helpful to someone, so I tried creating a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants