Limit attribute value length for pinpoint #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinpoint has a maximum number of characters per attribute value of 200: https://docs.aws.amazon.com/pinpoint/latest/developerguide/quotas.html#quotas-events This in particular applies to the referrer which an be very long. Better to limit the event than getting it rejected by pinpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinpoint has a maximum number of characters per attribute value of 200:
https://docs.aws.amazon.com/pinpoint/latest/developerguide/quotas.html#quotas-events
This in particular applies to the referrer which an be very long. Better
to limit the event than getting it rejected by pinpoint.
BTW: Any reason why the official pinpoint client is added as dependency but not used? https://github.com/DavidWells/analytics/blob/master/packages/analytics-plugin-aws-pinpoint/package.json#L72 I think that would catch issues like this client side.