Intercom updates #290
Open
Intercom updates #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deevus
force-pushed
the
intercom-user-hash
branch
from
b346d2d
to
05a50db
Compare
Have set the default types to the browser types There is currently no way to do isomorphic types See microsoft/TypeScript#29128
deevus
force-pushed
the
intercom-user-hash
branch
from
05a50db
to
27b621f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
userHashoption to Intercom configurationCan now configure an Intercom user hash as detailed here: https://www.intercom.com/help/en/articles/183-enable-identity-verification-for-web-and-mobile
Better TypeScript types for Intercom plugin
tsconfig.jsonfile for declaration emit configurationFixed a types issue with the
@analytics/types-utilpackageI don't know if this was working on your end, but
lerna run typesfailed before this change.Fixed
loaded()methodIntercom isn't actually loaded until
window.Intercom.bootedistrue