Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some Typos #75

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix some Typos #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce7cca7
Typos in WuAgent.cs
zolong1 Oct 25, 2019
0ff49c8
A typo fix
zolong1 Oct 27, 2019
5e9a3d1
Typo fix
zolong1 Oct 27, 2019
e791d35
Typo fix
zolong1 Oct 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wumgr/GPO.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ static public void ConfigSvc(string name, ServiceStartMode mode)
if (rule.IdentityReference.Value.Equals(FileOps.SID_System))
ac.RemoveAccessRule(rule);
}
// Note: windows tryes to re enable this services so we need to remove system write access
// Note: windows trys to re-enable this service so we need to remove system write access
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Note: windows trys to re-enable this service so we need to remove system write access
// Note: windows tries to re-enable this service so we need to remove system write access

if (mode == ServiceStartMode.Disabled) // add new rule
ac.AddAccessRule(new RegistryAccessRule(new SecurityIdentifier(FileOps.SID_System), RegistryRights.FullControl, AccessControlType.Deny));
subKey.SetAccessControl(ac);
Expand Down
2 changes: 1 addition & 1 deletion wumgr/UpdateDownloader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ private void DownloadNextFile()
mCurTask.Finished += OnFinished;
if (mCurTask.Start())
return;
// Failedto start this task lets try an otehr one
// Failed to start this task lets try another one
mCurrentTask++;
}

Expand Down
2 changes: 1 addition & 1 deletion wumgr/UpdateInstaller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ private void NextUpdate()
{
if (!Canceled && mUpdates.Count > mCurrentTask)
{
int Percent = 0; // Note: there does not seam to be an easy way to get this value
int Percent = 0; // Note: there does not seem to be an easy way to get this value
Progress?.Invoke(this, new WuAgent.ProgressArgs(mUpdates.Count, mUpdates.Count == 0 ? 0 : (100 * mCurrentTask + Percent) / mUpdates.Count, mCurrentTask + 1, Percent, mUpdates[mCurrentTask].Title));

if (DoInstall)
Expand Down
20 changes: 10 additions & 10 deletions wumgr/WuAgent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public WuAgent()

mUpdateSession = new UpdateSession();
mUpdateSession.ClientApplicationID = Program.mName;
//mUpdateSession.UserLocale = 1033; // alwys show strings in englisch
//mUpdateSession.UserLocale = 1033; // always show strings in english

mUpdateServiceManager = new UpdateServiceManager();

Expand Down Expand Up @@ -266,7 +266,7 @@ private RetCodes ClearOffline()
{
if (mOfflineService != null)
{
// note: if we keep references to updates reffering to an removed service we may got a crash
// note: if we keep references to updates reffering to a removed service we may get a crash
foreach (MsUpdate Update in mUpdateHistory)
Update.Invalidate();
foreach (MsUpdate Update in mPendingUpdates)
Expand Down Expand Up @@ -526,7 +526,7 @@ public RetCodes UnInstallUpdatesManually(List<MsUpdate> Updates)
return RetCodes.InProgress;
}

void DownloadsFinished(object sender, UpdateDownloader.FinishedEventArgs args) // "manuall" mode
void DownloadsFinished(object sender, UpdateDownloader.FinishedEventArgs args) // "manual" mode
{
if (mCurOperation == AgentOperation.CancelingOperation)
{
Expand All @@ -539,7 +539,7 @@ void DownloadsFinished(object sender, UpdateDownloader.FinishedEventArgs args) /
AppLog.Line("wsusscn2.cab downloaded");

RetCodes ret = ClearOffline();
if (ret == RetCodes.Success)
if (ret == RetCodes.Success)l
ret = SetupOffline();
if (ret == RetCodes.Success)
ret = SearchForUpdates();
Expand Down Expand Up @@ -593,7 +593,7 @@ void DownloadProgress(object sender, ProgressArgs args)
OnProgress(args.TotalCount, args.TotalPercent, args.CurrentIndex, args.CurrentPercent, args.Info);
}

void InstallFinished(object sender, UpdateInstaller.FinishedEventArgs args) // "manuall" mode
void InstallFinished(object sender, UpdateInstaller.FinishedEventArgs args) // "manual" mode
{
if (args.Success)
{
Expand Down Expand Up @@ -1157,7 +1157,7 @@ public UpdateCallback(WuAgent agent)
// Implementation of ISearchCompletedCallback interface...
public void Invoke(ISearchJob searchJob, ISearchCompletedCallbackArgs e)
{
// !!! warning this function is invoced from a different thread !!!
// !!! warning this function is invoked from a different thread !!!
agent.mDispatcher.Invoke(new Action(() => {
agent.OnUpdatesFound(searchJob);
}));
Expand All @@ -1166,7 +1166,7 @@ public void Invoke(ISearchJob searchJob, ISearchCompletedCallbackArgs e)
// Implementation of IDownloadProgressChangedCallback interface...
public void Invoke(IDownloadJob downloadJob, IDownloadProgressChangedCallbackArgs callbackArgs)
{
// !!! warning this function is invoced from a different thread !!!
// !!! warning this function is invoked from a different thread !!!
agent.mDispatcher.Invoke(new Action(() => {
agent.OnProgress(downloadJob.Updates.Count, callbackArgs.Progress.PercentComplete, callbackArgs.Progress.CurrentUpdateIndex + 1,
callbackArgs.Progress.CurrentUpdatePercentComplete, downloadJob.Updates[callbackArgs.Progress.CurrentUpdateIndex].Title);
Expand All @@ -1176,7 +1176,7 @@ public void Invoke(IDownloadJob downloadJob, IDownloadProgressChangedCallbackArg
// Implementation of IDownloadCompletedCallback interface...
public void Invoke(IDownloadJob downloadJob, IDownloadCompletedCallbackArgs callbackArgs)
{
// !!! warning this function is invoced from a different thread !!!
// !!! warning this function is invoked from a different thread !!!
agent.mDispatcher.Invoke(new Action(() => {
agent.OnUpdatesDownloaded(downloadJob, downloadJob.AsyncState);
}));
Expand All @@ -1185,7 +1185,7 @@ public void Invoke(IDownloadJob downloadJob, IDownloadCompletedCallbackArgs call
// Implementation of IInstallationProgressChangedCallback interface...
public void Invoke(IInstallationJob installationJob, IInstallationProgressChangedCallbackArgs callbackArgs)
{
// !!! warning this function is invoced from a different thread !!!
// !!! warning this function is invoked from a different thread !!!
agent.mDispatcher.Invoke(new Action(() => {
agent.OnProgress(installationJob.Updates.Count, callbackArgs.Progress.PercentComplete, callbackArgs.Progress.CurrentUpdateIndex + 1,
callbackArgs.Progress.CurrentUpdatePercentComplete, installationJob.Updates[callbackArgs.Progress.CurrentUpdateIndex].Title);
Expand All @@ -1195,7 +1195,7 @@ public void Invoke(IInstallationJob installationJob, IInstallationProgressChange
// Implementation of IInstallationCompletedCallback interface...
public void Invoke(IInstallationJob installationJob, IInstallationCompletedCallbackArgs callbackArgs)
{
// !!! warning this function is invoced from a different thread !!!
// !!! warning this function is invoked from a different thread !!!
agent.mDispatcher.Invoke(new Action(() => {
agent.OnInstalationCompleted(installationJob, installationJob.AsyncState);
}));
Expand Down