Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate vector json schema #27

Merged
merged 8 commits into from
Mar 26, 2024

Conversation

xyj-3
Copy link
Contributor

@xyj-3 xyj-3 commented Mar 24, 2024

Issue #6

.github/workflows/validate-vector.yaml Show resolved Hide resolved
src/validate.py Show resolved Hide resolved
src/vector.schema.yaml Show resolved Hide resolved
@xyj-3 xyj-3 changed the title Validate vector.json schema Validate vector json schema Mar 24, 2024
@xyj-3
Copy link
Contributor Author

xyj-3 commented Mar 25, 2024

Updated
I made action-validator stop failing due to not checked out globs being named in validate-vector action by making it check out the entire repo. I can undo it if you actually intended for action-validator to fail every time, or change it to exclude running on that one file.

@kevinlul
Copy link
Contributor

Revert that, action_validator is flawed as it doesn't parse globs like GitHub actually does. It's only for reference.

@xyj-3
Copy link
Contributor Author

xyj-3 commented Mar 25, 2024

Updated
Wait while I check what I did to action-validator.yaml

@xyj-3 xyj-3 marked this pull request as draft March 25, 2024 22:16
@xyj-3 xyj-3 marked this pull request as ready for review March 25, 2024 22:18
Copy link
Contributor

@kevinlul kevinlul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping with this.

@kevinlul kevinlul merged commit a12ce76 into DawnbrandBots:master Mar 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants