Fix last character in ASCII selection. #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument n is a "size" rather than a "last element". Without this the last character is not selected -space for hex -but more importantly the last ascii too Dax89#63 Signed-off-by: Andrea Odetti <[email protected]>
audetto
changed the title
…elected. It looks better. Signed-off-by: Andrea Odetti <[email protected]>
Signed-off-by: Andrea Odetti <[email protected]>
|
Merged, thanks! Be aware that I'm doing (in my free time) a partial rewrite of this widget which make code easier to extend and maintain. |
|
Can we see it? |
|
Currently is in early stage, not much too see. When it's almost usable I will commit it in a separate branch so I doesn't break the master one and it can be tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this the last character is not selected
-space for hex
-but more importantly the last ascii too
#63
Signed-off-by: Andrea Odetti [email protected]