Skip to content

Commit

Permalink
chore enable app signing for mac (#1279)
Browse files Browse the repository at this point in the history
* chore enable app signing for mac

* updated electron-notarize
  • Loading branch information
fullstackninja864 authored Nov 23, 2023
1 parent 4bddb58 commit 050d228
Show file tree
Hide file tree
Showing 5 changed files with 89 additions and 100 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/dev-builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ jobs:
CI: true
APPLE_ID: ${{ secrets.APPLE_ID}}
APPLE_ID_PASS: ${{ secrets.APPLE_ID_PASS}}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_ID_PASS}}
CSC_FOR_PULL_REQUEST: true

- uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8
with:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/release-builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ jobs:
APPLE_ID: ${{ secrets.APPLE_ID}}
APPLE_ID_PASS: ${{ secrets.APPLE_ID_PASS}}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_ID_PASS}}
# Disable code signing
CSC_IDENTITY_AUTO_DISCOVERY: false

create-mac-checksum:
needs:
Expand Down
2 changes: 1 addition & 1 deletion electron-app/assets/notarize.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { notarize } = require('@electron/notarize');
const { notarize } = require('electron-notarize');
const { build } = require('../../package.json');

exports.default = async function notarizeMacOS(context) {
Expand Down
179 changes: 84 additions & 95 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"crypto-js": "^4.1.1",
"electron-debug": "^3.2.0",
"electron-log": "^4.4.8",
"electron-notarize": "^1.2.2",
"electron-progressbar": "^2.0.1",
"electron-updater": "5.3.0",
"foreman": "^3.0.1",
Expand All @@ -80,7 +81,6 @@
},
"devDependencies": {
"@babel/preset-typescript": "^7.16.7",
"@electron/notarize": "^2.2.0",
"@electron/typescript-definitions": "^8.10.0",
"@types/auto-launch": "^5.0.2",
"@types/base-64": "^1.0.0",
Expand Down Expand Up @@ -116,6 +116,7 @@
"appId": "com.defichain.DeFiWallet",
"copyright": "Copyright © 2020-2023 ${author}",
"asar": true,
"afterSign": "electron-app/assets/notarize.js",
"files": [
"./electron-app/build",
{
Expand Down Expand Up @@ -163,7 +164,6 @@
"mac": {
"category": "public.app-category.finance",
"target": ["dmg"],
"notarize": false,
"type": "distribution",
"hardenedRuntime": true,
"entitlements": "electron-app/assets/entitlements.mac.plist",
Expand Down

0 comments on commit 050d228

Please sign in to comment.