Price info styling #126
Merged
Price info styling #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chipper-sunburst-578cfe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EvgeniiaVak
requested changes
Sep 25, 2023
|
Updated with suggestions |
EvgeniiaVak
requested changes
Sep 26, 2023
There was a problem hiding this comment.
I just checked on https://deploy-preview-126--chipper-sunburst-578cfe.netlify.app/
it says +1.28% but the color is red. Something is wrong here. Either the change is actually negative or the color should be green (if we go with the green/red colors changing still, if we go with accent it's always one color).
|
@EvgeniiaVak you are correct I made a typo when swapping out the colors. Personally I like the change in color, but this is a very easy tweak if we get consensus in the future. |
EvgeniiaVak
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
