Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pair selector and style #130

Merged

Conversation

nguvictor
Copy link
Member

Fixes #122
swap-pair

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for chipper-sunburst-578cfe ready!

Name Link
🔨 Latest commit c76ae79
🔍 Latest deploy log https://app.netlify.com/sites/chipper-sunburst-578cfe/deploys/651439fe0fee00000837ded1
😎 Deploy Preview https://deploy-preview-130--chipper-sunburst-578cfe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nguvictor nguvictor changed the title styling and positioning pair selector and style Sep 26, 2023
Copy link
Member

@EvgeniiaVak EvgeniiaVak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is off with paddings / margins there, the selector looks a little bit out of position.

Screenshot 2023-09-26 at 16 39 51

Also background color - maybe making it the same as for other components (like in figma)?

src/app/components/PairSelector.tsx Outdated Show resolved Hide resolved
@nguvictor
Copy link
Member Author

It looks like the colors are a bit off in the theme. The figma says #191B1D which is base-100 in the theme. But the color for the rest of the background items are #1a1c1e. We might want another issue to line up the colors across the dapp.

image

{pair.name}
<span>+</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a + sign?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The figma had a + sign, I could of used a svg icon, but seemed overkill. I suspect this will be a favorite button in the future, but its a placeholder for now.

@EvgeniiaVak
Copy link
Member

EvgeniiaVak commented Sep 27, 2023

I suggest to remove bg color at all and use the default one, and then change the default one for the correct #191B1D (either in a separate pr or here) ah, that's a button, it's default color is different, never mind

@EvgeniiaVak EvgeniiaVak merged commit a49f31f into DeXter-on-Radix:main Sep 27, 2023
4 checks passed
@nguvictor nguvictor deleted the pair-selector-style-shortcut branch October 2, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Pair selector styling + shortcut
2 participants