Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pair selector imporvements #236

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Pair selector imporvements #236

merged 2 commits into from
Jan 28, 2024

Conversation

EvgeniiaVak
Copy link
Member

fixes #219
fixes #154

  • fixes strange bottom margin
  • adds shortcuts for search - /, enter, esc, arrows
  • fixes the (i) info label showing up on top of the options
  • adds scrollbar (not visible unless we have more pairs)

Copy link

netlify bot commented Jan 27, 2024

Deploy Preview for chipper-sunburst-578cfe ready!

Name Link
🔨 Latest commit 9729953
🔍 Latest deploy log https://app.netlify.com/sites/chipper-sunburst-578cfe/deploys/65b4ffde9d27480008a55dc4
😎 Deploy Preview https://deploy-preview-236--chipper-sunburst-578cfe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Radstakes Radstakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great Ev, I like the keyboard shortcut and the search function will be really useful as we list more pairs. I can't read the code but the preview works great so approving on that basis.

@nguvictor
Copy link
Member

nguvictor commented Jan 28, 2024

Minor might be better as as different issue, but I get an auto complete that pops up. Might be my browser though. Otherwise this was a massive improvement. Great job!
image

@EvgeniiaVak
Copy link
Member Author

@nguvictor yeah, the popup looks weird, maybe I can disable it somehow, what's your browser?

@EvgeniiaVak EvgeniiaVak merged commit d9643cc into main Jan 28, 2024
5 checks passed
@EvgeniiaVak EvgeniiaVak deleted the pair-selector-imporvements branch January 28, 2024 07:30
@nguvictor
Copy link
Member

nguvictor commented Jan 29, 2024

@EvgeniiaVak
It's Brave browser
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Token Selection Drop Down UI Issue with "i" tooltip on Post Only Pair selector improvements
3 participants