Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch delete orders #465

Merged
merged 14 commits into from
Jun 27, 2024
Merged

Batch delete orders #465

merged 14 commits into from
Jun 27, 2024

Conversation

dcts
Copy link
Contributor

@dcts dcts commented Jun 25, 2024

This PR implements a feature where the user can cancel multiple orders at once, with a maximum capped at 8 orders.

Features (to test):

  • accountHistory table rows now have a hover state for better UX
  • batch deletion: select / deselect orders
  • batch deletion: delete X orders
  • single deletion should still work, the functionality is shown on hover state but is disabled once the user selects the order for batch deletion.

Preview

batchDeletion-preview

@dcts dcts requested a review from a team as a code owner June 25, 2024 23:13
Copy link

cloudflare-workers-and-pages bot commented Jun 25, 2024

Deploying dexter with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3dd85d8
Status: ✅  Deploy successful!
Preview URL: https://428e1b36.dexter-1we.pages.dev
Branch Preview URL: https://batch-delete-orders.dexter-1we.pages.dev

View logs

@nguvictor
Copy link
Member

photo_2024-06-26_15-52-45
image

I appear to have COMPLETED orders in my open orders tab, but for some reason the json is returning PENDING

image

@dcts
Copy link
Contributor Author

dcts commented Jun 26, 2024

@nguvictor does the same happen when you try to delete such an order using the "Delete Single Order" button (on hover)? If yes I suggest to create a separate issue for this, as it seems to be a weird bug regarding the orders being displayed rather than related to the batch deletion feature.

Also the timeCompleted looks suspicious (1970), maybe this is a adex bug we should report in adex telegram chat?

@dcts dcts merged commit 8ef0d36 into main Jun 27, 2024
2 checks passed
@dcts dcts deleted the batch-delete-orders branch June 27, 2024 16:08
@dcts dcts mentioned this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants