Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rootlayout server component #515

Closed

Conversation

SiegfriedBz
Copy link
Contributor

@SiegfriedBz SiegfriedBz commented Jul 29, 2024

Refactor RootLayout: Transform from Client to Server Component

  • remove use client directive from RootLayout
  • extract the store provider and the AppBody components into client components
  • update dependency tree

@SiegfriedBz SiegfriedBz requested a review from a team as a code owner July 29, 2024 12:44
Copy link

cloudflare-workers-and-pages bot commented Jul 29, 2024

Deploying dexter with  Cloudflare Pages  Cloudflare Pages

Latest commit: 49d3484
Status: ✅  Deploy successful!
Preview URL: https://2a633a8e.dexter-1we.pages.dev
Branch Preview URL: https://fork-siegfriedbz--make-rootl.dexter-1we.pages.dev

View logs

@dcts dcts changed the title Fork siegfried bz make rootlayout server component make rootlayout server component Jul 29, 2024
@dcts
Copy link
Contributor

dcts commented Aug 3, 2024

@SiegfriedBz can you turn this into a PR draft until we have tested/discussion this? :)

@SiegfriedBz SiegfriedBz marked this pull request as draft August 3, 2024 07:43
@dcts dcts self-assigned this Aug 7, 2024
@SiegfriedBz SiegfriedBz reopened this Aug 26, 2024
@SiegfriedBz SiegfriedBz reopened this Oct 5, 2024
@SiegfriedBz SiegfriedBz marked this pull request as ready for review October 5, 2024 06:05
@SiegfriedBz SiegfriedBz requested a review from Radstakes October 23, 2024 19:40
@SiegfriedBz SiegfriedBz marked this pull request as draft October 23, 2024 19:41
@dcts
Copy link
Contributor

dcts commented Nov 1, 2024

We decided to stay a client side app using SSG for now.

@dcts dcts closed this Nov 1, 2024
@dcts dcts deleted the fork-SiegfriedBz--make-rootlayout-server-component branch November 1, 2024 20:53
@DeXter-on-Radix DeXter-on-Radix deleted a comment from SiegfriedBz Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants