Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation issues #533

Merged
merged 8 commits into from
Aug 8, 2024
Merged

Fix translation issues #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fca0fc7
add translations to navbar items
dcts Aug 2, 2024
f0d6bd7
fix translations from the translation issue google doc
dcts Aug 2, 2024
ecb6d19
fix linter errors
dcts Aug 2, 2024
b2996d7
Merge branch 'main' into fix-translation-bugs
dcts Aug 4, 2024
01c9511
Merge branch 'main' into fix-translation-bugs
dcts Aug 5, 2024
42e6620
fix linter issues
dcts Aug 5, 2024
f2a7387
fix another reported translation issue
dcts Aug 7, 2024
13934e3
Merge branch 'main' into fix-translation-bugs
dcts Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/app/components/NavBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ import Image from "next/image";
import Link from "next/link";

import { useSelector } from "react-redux";
import { useAppDispatch, useAppSelector, useHydrationErrorFix } from "hooks";
import {
useAppDispatch,
useAppSelector,
useHydrationErrorFix,
useTranslations,
} from "hooks";
import { getSupportedLanguagesAsString } from "../state/i18nSlice";

import { i18nSlice } from "../state/i18nSlice";
Expand Down Expand Up @@ -32,11 +37,11 @@ interface NavbarItemMobileProps extends NavbarItemProps {
const NavItems: { path: string; title: string }[] = [
{
path: "/trade",
title: "Trade",
title: "trade",
},
{
path: "/rewards",
title: "Rewards",
title: "rewards",
},
];

Expand Down Expand Up @@ -219,13 +224,14 @@ function Logo() {
}

function NavbarItemsDesktop() {
const t = useTranslations();
return (
<>
<div className="hidden sm:flex h-full items-center flex-1 px-2 mx-2 z-10">
{NavItems.map((navItem, indx) => {
return (
<NavbarItemDesktop
title={navItem.title}
title={t(navItem.title)}
target={navItem.path}
key={indx}
/>
Expand Down
4 changes: 2 additions & 2 deletions src/app/state/locales/pt/rewards.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
"next_distribution": "Próxima distribuição",
"total_rewards": "Total de recompensas",
"claim_all_rewards": "Reivindicar todas",
"learn_more_about_rewards": "Saiba mais sobre a recompensas",
"learn_more_about_rewards": "Saiba mais sobre recompensas",
"claiming_rewards_loading": "Reivindicando recompensas...",
"claiming_rewards_success": "Recompensas reivindicadas",
"claiming_rewards_fail": "Erro ao reivindicar recompensas",
"how_did_everything_go": "Como tudo ocorreu? Envie um feedback",
"rewards_claimed": "Recompensas resgatadas",
"continue_trading_to_earn_more": "Continue negociando ou fazendo staking para ganhar mais e volte mais tarde.",
"go_back": "Voltar",
"no_rewards_to_claim": "Sem recompensas para reivindica",
"no_rewards_to_claim": "Sem recompensas para reivindicar",
"loading...": "Carregamento..."
}
6 changes: 3 additions & 3 deletions src/app/state/locales/pt/trade.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"order_price": "Preço",
"filled_qty": "Qtd preenchida",
"completed_perc": "Concluído (%)",
"action": "Açâo",
"action": "Ação",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks the same to me?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol 🤣 yeah to me too, but its not, look closer! ;)

"status": "Status",
"pending": "Pendente",
"completed": "Completo",
Expand All @@ -62,8 +62,8 @@
"transaction_in_progress": "Transação em andamento...",
"best_buy": "Melhor compra",
"best_sell": "Melhor venda",
"no_order_history": "Sem histórico de pedidos",
"no_active_orders": "Sem pedidos ativos",
"no_order_history": "Sem histórico de ordens",
"no_active_orders": "Sem ordens ativas",
"no_trade_history": "Sem histórico de negociações",
"no_trades_have_occured_yet": "Nenhuma transação foi realizada ainda",
"market_action_token": "<$SIDE> <$TOKEN_SYMBOL> a <$ORDER_TYPE>",
Expand Down
Loading