Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the PairSelector menu to close when clicking outside the menu #537

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

SiegfriedBz
Copy link
Contributor

Resolves #518

@SiegfriedBz SiegfriedBz requested a review from a team as a code owner August 4, 2024 03:45
Copy link

Deploying dexter with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4d41f0b
Status: ✅  Deploy successful!
Preview URL: https://a1d98a91.dexter-1we.pages.dev
Branch Preview URL: https://fork-siegfriedbz--close-pair.dexter-1we.pages.dev

View logs

@yuliaSharabi
Copy link
Contributor

ESC click is not implemented in it(see the issue #518)

@SiegfriedBz
Copy link
Contributor Author

But as it is, ESC click actually works on my end.. does it not ?..

@dcts
Copy link
Contributor

dcts commented Aug 4, 2024

Yes ESC key should work as it was already implemented.

@yuliaSharabi if ESC key doesnt close the menu for you, please open a new issue.

Thanks for fixing! 👍

@dcts dcts merged commit 88916b0 into main Aug 4, 2024
2 checks passed
@dcts dcts deleted the fork-SiegfriedBz--close-pair-selector-dropdown branch August 4, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Close Pair Selector Dropdown on Outside Click or ESC Key Press
3 participants