-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PairInfo tab #544
Add PairInfo tab #544
Conversation
Deploying dexter with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ow-resource-addresses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more improvements:
- The two coin boxes should both take up exactly 50% of the full space, to align with the orderrInput and orderBook components. Currently left box it too small for viewport width of 740px, and for 840px viewportwidth the right box is too small. I think you can just add a "flex-grow" on both elements, but probably will need to fix also oversizing in case the content is too big.
- I think to be consistent, all those elements marked red should have the same bottom margin. I suggest
mb-1
for all those elements (maybe you'll need to use!mb-1
for<p>
elements.
-
Please use the shortenString function to display a shorter version of the addresses, I suggest to use 20 for
showEnd
and to setshowStart
in a way that will show "resource..." or "component...", so either 8 or 9. This is a pattern shared among all crypto space, as people usually check the last few characters of an address. -
Can you add
px-2
to both nav elements (Price chart + Pair info) to space out the tabs a bit?
- Not neccesarily needed, but when copying it would be awesome if the user would get a feedback, something similar to this (found here)
…ow-resource-addresses
…ow-resource-addresses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Great work with the refactor and all the changes made!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
solves #432
Added a tab for PairInfo.