-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animate Landing Page Lights #556
Conversation
Deploying dexter with Cloudflare Pages
|
tailwind.config.js
Outdated
blueLight: "blueLight 12s ease-in-out infinite", | ||
greenLight: "breenLight 12s ease-in-out infinite", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we try setting this to 9s just to test? I feel currently it is too subtle such that it very barely gets noticed. Something in-between the first iteration and this one would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the typo and pushed the 12s version again, but in any case I will upload the 9s video on discord for comparison
src/app/page.tsx
Outdated
@@ -3,12 +3,13 @@ | |||
import { DexterButton } from "components/DexterButton"; | |||
import StatsWidget from "components/StatsWidget"; | |||
import { useTranslations, useHydrationErrorFix } from "hooks"; | |||
// import * as tailwindConfig from "../../../tailwind.config"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove outcommented line
src/app/page.tsx
Outdated
|
||
enum Device { | ||
MOBILE = "MOBILE", | ||
DESKTOP = "DESKTOP", | ||
} | ||
|
||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove empty comment
tailwind.config.js
Outdated
// stretch the grid so that footer is always at the bottom | ||
// even on pages with little content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this comment removed? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saidam90 if you think this comment should be removed, please open a new PR with a reason why it should be removed :)
@saidam90 Looks great now, happy to merge once comments get resolved! 💯 |
remove unneeded comments
Revert deleting relevant comment
Just realized since the requested changes are so minor I can implement and commit directly. |
@fliebenberg can you approve + merge this PR? I did, but since I made a small commit (just removing comments), I believe another maintainer review is required. |
solves #504
Animated lights, increased the size of lights (x3) and stretched the animation to 12s.