Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate Landing Page Lights #556

Merged
merged 11 commits into from
Aug 20, 2024
Merged

Animate Landing Page Lights #556

merged 11 commits into from
Aug 20, 2024

Conversation

saidam90
Copy link
Contributor

@saidam90 saidam90 commented Aug 11, 2024

solves #504

Animated lights, increased the size of lights (x3) and stretched the animation to 12s.

@saidam90 saidam90 requested a review from a team as a code owner August 11, 2024 21:28
Copy link

cloudflare-workers-and-pages bot commented Aug 11, 2024

Deploying dexter with  Cloudflare Pages  Cloudflare Pages

Latest commit: ae4d953
Status: ✅  Deploy successful!
Preview URL: https://3335a054.dexter-1we.pages.dev
Branch Preview URL: https://landing-page-lights.dexter-1we.pages.dev

View logs

src/app/page.tsx Outdated Show resolved Hide resolved
Comment on lines 52 to 53
blueLight: "blueLight 12s ease-in-out infinite",
greenLight: "breenLight 12s ease-in-out infinite",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try setting this to 9s just to test? I feel currently it is too subtle such that it very barely gets noticed. Something in-between the first iteration and this one would be great.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the typo and pushed the 12s version again, but in any case I will upload the 9s video on discord for comparison

src/app/page.tsx Outdated
@@ -3,12 +3,13 @@
import { DexterButton } from "components/DexterButton";
import StatsWidget from "components/StatsWidget";
import { useTranslations, useHydrationErrorFix } from "hooks";
// import * as tailwindConfig from "../../../tailwind.config";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove outcommented line

src/app/page.tsx Outdated

enum Device {
MOBILE = "MOBILE",
DESKTOP = "DESKTOP",
}

//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty comment

Comment on lines 22 to 23
// stretch the grid so that footer is always at the bottom
// even on pages with little content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this comment removed? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saidam90 if you think this comment should be removed, please open a new PR with a reason why it should be removed :)

@dcts
Copy link
Contributor

dcts commented Aug 17, 2024

@saidam90 Looks great now, happy to merge once comments get resolved! 💯

dcts added 2 commits August 18, 2024 01:47
remove unneeded comments
Revert deleting relevant comment
@dcts
Copy link
Contributor

dcts commented Aug 17, 2024

Just realized since the requested changes are so minor I can implement and commit directly.

@dcts
Copy link
Contributor

dcts commented Aug 17, 2024

@fliebenberg can you approve + merge this PR? I did, but since I made a small commit (just removing comments), I believe another maintainer review is required.

@Radstakes Radstakes merged commit 95188e9 into main Aug 20, 2024
2 checks passed
@Radstakes Radstakes deleted the landing-page-lights branch August 20, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants