fix: test for arm64 architecture properly in MP3DecoderTests #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accidental commit of dspconfig file? |
rsekman
force-pushed
the
fix/arm64_mp3_decoder_tests
branch
from
583d111 to
1dda8cf
Compare
|
Yes 🤦♂️, fixed; thanks for pointing it out. |
|
@rsekman can you please rebase on latest master and rerun CI jobs? |
on arm64/aarch64 libmpg123 generates bad data leading to the test MP3DecoderTests.test_DecodeMP3As2PiecesMPG123_SameAs1Piece failing. this test was excluded by testing for the TARGET_CPU_ARM64 macro. but this is an Xcode macro defined in TargetConditionals.h. thus the test would not be excluded when compiling on a device such as the Raspberry Pi 4 or 5. the portable way to test for arm64 architecture with clang is to check for __aarch64__: https://stackoverflow.com/a/41666292
rsekman
force-pushed
the
fix/arm64_mp3_decoder_tests
branch
from
1dda8cf to
d3cc85e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on arm64/aarch64 libmpg123 generates bad data leading to the test MP3DecoderTests.test_DecodeMP3As2PiecesMPG123_SameAs1Piece failing. this test was excluded by testing for the
TARGET_CPU_ARM64macro. but this is an Xcode macro defined inTargetConditionals.h. thus the test would not be excluded when compiling on a device such as the Raspberry Pi 4 or 5. the portable way to test for arm64 architecture with clang is to check for__aarch64__: https://stackoverflow.com/a/41666292