fix #3127 (autosort) #3128
Merged
fix #3127 (autosort) #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good, but I can't merge this PR before the tests are green. If you need to have the failing test in the code -- you'd have to disable it before merging. |
|
I have played around with calling plt_ausort, and I can confirm it's quite broken. Every time it's called, it corrupts the previous settings. |
|
The tests should be green after you rebase on master. |
rsekman
force-pushed
the
fix/autosort
branch
from
1221954 to
e66b7c4
Compare
This reverts commit 8d7bc97.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft to resolve #3127. It adds tests for sorting playlists directly and with autosort, plus some tweaks to the test suite (build with debuginfo, link with lld for better error messages).