Skip to content

fix: size_t warning fix, house robber 2 init #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace MinimumCostClimbingStairs
class DynamicProgramming
{
private:
int MinCostRecursive(int step, vector<int>& cost);
int MinCostRecursive(size_t step, vector<int>& cost);
public:
int RecursiveMinimumCostClimbingStairs(vector<int>& cost);
int DpMinimumCostClimbingStairs(vector<int>& cost);
Expand Down
2 changes: 1 addition & 1 deletion include/0005_DynamicProgramming/0005_HouseRobber1.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace HouseRobber1
class DynamicProgramming
{
private:
int MaxLootRecursive(int house, vector<int>& houseValues);
int MaxLootRecursive(size_t house, vector<int>& houseValues);
public:
int RecursiveMaximumLoot(vector<int>& houseValues);
int DpMaximumLoot(vector<int>& houseValues);
Expand Down
28 changes: 28 additions & 0 deletions include/0005_DynamicProgramming/0006_HouseRobber2.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
#pragma once
#include<vector>
using namespace std;

/*
Pattern 1
Linear Recurrence

Description
You are given an array arr[] which represents houses arranged in a circle, where each house has a certain value. A thief aims to maximize the total stolen value without robbing two adjacent houses.
Determine the maximum amount the thief can steal.

Note: Since the houses are in a circle, the first and last houses are also considered adjacent.

*/

namespace HouseRobber2
{
class DynamicProgramming
{
private:
int MaxLootRecursive(size_t house, vector<int>& houseValues);
int MaxLootDp(size_t firstHouse, size_t lastHouse, vector<int>& houseValues);
public:
int RecursiveMaximumLoot(vector<int>& houseValues);
int DpMaximumLoot(vector<int>& houseValues);
};
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace MinimumCostClimbingStairs
{
int DynamicProgramming::MinCostRecursive(int step, vector<int>& cost)
int DynamicProgramming::MinCostRecursive(size_t step, vector<int>& cost)
{
if (step == 0 || step == 1)
{
Expand All @@ -15,7 +15,7 @@ namespace MinimumCostClimbingStairs

int DynamicProgramming::RecursiveMinimumCostClimbingStairs(vector<int>& cost)
{
int totalSteps = cost.size();
size_t totalSteps = cost.size();

if (totalSteps == 1)
{
Expand All @@ -27,7 +27,7 @@ namespace MinimumCostClimbingStairs

int DynamicProgramming::DpMinimumCostClimbingStairs(vector<int>& cost)
{
int totalSteps = cost.size();
size_t totalSteps = cost.size();
vector<int> dp(totalSteps, 0);

if (totalSteps == 1)
Expand All @@ -38,7 +38,7 @@ namespace MinimumCostClimbingStairs
dp[0] = cost[0];
dp[1] = cost[1];

for (int i = 2; i < totalSteps; i++)
for (size_t i = 2; i < totalSteps; i++)
{
dp[i] = cost[i] + min(dp[i - 1], dp[i - 2]);
}
Expand Down
8 changes: 4 additions & 4 deletions source/0005_DynamicProgramming/0005_HouseRobber1.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace HouseRobber1
{
int DynamicProgramming::MaxLootRecursive(int house, vector<int>& houseValues)
int DynamicProgramming::MaxLootRecursive(size_t house, vector<int>& houseValues)
{
if (house <= 0)
{
Expand All @@ -22,19 +22,19 @@ namespace HouseRobber1

int DynamicProgramming::RecursiveMaximumLoot(vector<int>& houseValues)
{
int totalNumberOfHouses = houseValues.size();
size_t totalNumberOfHouses = houseValues.size();
return this->MaxLootRecursive(totalNumberOfHouses, houseValues);
}

int DynamicProgramming::DpMaximumLoot(vector<int>& houseValues)
{
int totalNumberOfHouses = houseValues.size();
size_t totalNumberOfHouses = houseValues.size();
vector<int> dp(totalNumberOfHouses + 1, 0);

dp[0] = 0;
dp[1] = houseValues[0];

for (int i = 2; i <= totalNumberOfHouses; i++)
for (size_t i = 2; i <= totalNumberOfHouses; i++)
{
dp[i] = max(dp[i - 2] + houseValues[i - 1], dp[i - 1]);
}
Expand Down
95 changes: 95 additions & 0 deletions source/0005_DynamicProgramming/0006_HouseRobber2.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
#include "../../include/0005_DynamicProgramming/0006_HouseRobber2.h"

namespace HouseRobber2
{
int DynamicProgramming::MaxLootRecursive(size_t house, vector<int>& houseValues)
{
if (house <= 0)
{
return 0;
}

if (house == 1)
{
return houseValues[0];
}

int pickCurrentHouse = houseValues[house - 1] + this->MaxLootRecursive(house - 2, houseValues);
int dropCurrentHouse = this->MaxLootRecursive(house - 1, houseValues);

return max(pickCurrentHouse, dropCurrentHouse);
}

int DynamicProgramming::MaxLootDp(size_t firstHouse, size_t lastHouse, vector<int>& houseValues)
{
int totalNumberOfHouses = lastHouse - firstHouse + 1;

if (totalNumberOfHouses == 0)
{
return 0;
}

if (totalNumberOfHouses == 1)
{
return houseValues[firstHouse];
}

vector<int> dp(totalNumberOfHouses, 0);

dp[0] = houseValues[firstHouse];
dp[1] = max(houseValues[firstHouse], houseValues[firstHouse + 1]);

for (size_t i = 2; i < totalNumberOfHouses; i++)
{
dp[i] = max(houseValues[firstHouse + i] + dp[i - 2], dp[i - 1]);
}

return dp[totalNumberOfHouses - 1];
}

int DynamicProgramming::RecursiveMaximumLoot(vector<int>& houseValues)
{
if (houseValues.size() == 0)
{
return 0;
}

if (houseValues.size() == 1)
{
return houseValues[0];
}

size_t totalNumberOfHouses = houseValues.size()-1;

// Case 1: Exclude last house.
vector<int> pickFirstHouse(houseValues.begin(), houseValues.end() - 1);

// Case 2: Exlcude first house.
vector<int> pickLastHouse(houseValues.begin() + 1, houseValues.end());

return max(this->MaxLootRecursive(totalNumberOfHouses, pickFirstHouse), this->MaxLootRecursive(totalNumberOfHouses, pickLastHouse));
}

int DynamicProgramming::DpMaximumLoot(vector<int>& houseValues)
{
size_t totalNumberOfHouses = houseValues.size();

if (totalNumberOfHouses == 0)
{
return 0;
}

if (totalNumberOfHouses == 1)
{
return houseValues[0];
}

// Case 1: Exclude last house.
int pickFirstHouse = this->MaxLootDp(0, totalNumberOfHouses - 2, houseValues);

// Case 2: Exlcude first house.
int pickLastHouse = this->MaxLootDp(1, totalNumberOfHouses - 1, houseValues);

return max(pickFirstHouse, pickLastHouse);
}
}
1 change: 1 addition & 0 deletions source/0005_DynamicProgramming/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ set(0005DYNAMICPROGRAMMING_SOURCES
0003_ClimbingStairs.cc
0004_MinimumCostClimbingStairs.cc
0005_HouseRobber1.cc
0006_HouseRobber2.cc

)

Expand Down
48 changes: 48 additions & 0 deletions test/0005_DynamicProgramming/0006_HouseRobber2Test.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
#include<gtest/gtest.h>
#include "../../include/0005_DynamicProgramming/0006_HouseRobber2.h"

namespace HouseRobber2
{
TEST(HouseRobber2, RecursionTest01)
{
// Arrange
DynamicProgramming dp;
vector<int> houseValues = { 2, 2, 3, 1, 2 };
int expectedMaximumLoot = 5;

// Act
int actualMaximumLoot = dp.RecursiveMaximumLoot(houseValues);

// Assert
ASSERT_EQ(expectedMaximumLoot, actualMaximumLoot);
}

TEST(HouseRobber2, DpTest01)
{
// Arrange
DynamicProgramming dp;
vector<int> houseValues = { 2, 2, 3, 1, 2 };
int expectedMaximumLoot = 5;

// Act
int actualMaximumLoot = dp.DpMaximumLoot(houseValues);

// Assert
ASSERT_EQ(expectedMaximumLoot, actualMaximumLoot);
}

TEST(HouseRobber2, DpTest02)
{
// Arrange
DynamicProgramming dp;
vector<int> houseValues = { 9, 1, 8, 2 };
int expectedMaximumLoot = 17;

// Act
int actualMaximumLoot = dp.DpMaximumLoot(houseValues);

// Assert
ASSERT_EQ(expectedMaximumLoot, actualMaximumLoot);
}

}
1 change: 1 addition & 0 deletions test/0005_DynamicProgramming/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ add_executable(
0003_ClimbingStairsTest.cc
0004_MinimumCostClimbingStairsTest.cc
0005_HouseRobber1Test.cc
0006_HouseRobber2Test.cc

)

Expand Down
Loading