fix: issue #18 - Duplicate default strings.xml #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienbusin
force-pushed
the
fix/defaultLanguage
branch
from
77f558a to
2b96e87
Compare
GerardPaligot
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy default file strings.xml to value-DEFAULT_LANGUAGE/strings.xml if there is no variant, default file will be taken instead so we don't need to copy it.
This corrects this issue : #18
When a default language (ex: "en") has some variants (ex: en-GB) which have a translation which is different between them, before this fix, there was no values-en file created, so, for an other variant (ex: en-IE) the translation will be pull from en-GB and not from "en".
See google "resource resolution order" doc for more details -> https://developer.android.com/guide/topics/resources/multilingual-support?hl=fr#resource-resolution-examples