Added Validation for set card rarity

DecentralCardGame · Sep 27, 2023 · da95e16 · da95e16
1 parent 158c72d
commit da95e16
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/x/cardchain/client/cli/tx_set_card_rarity.go b/x/cardchain/client/cli/tx_set_card_rarity.go
@@ -1,6 +1,7 @@
 package cli
 
 import (
+	"github.com/DecentralCardGame/cardobject/cardobject"
 	"strconv"
 
 	"github.com/DecentralCardGame/Cardchain/x/cardchain/types"
@@ -29,6 +30,12 @@ func CmdSetCardRarity() *cobra.Command {
 			}
 			argRarity := args[2]
 
+			rarity := cardobject.Rarity(argRarity)
+			err = rarity.ValidateType(cardobject.Card{})
+			if err != nil {
+				return err
+			}
+
 			clientCtx, err := client.GetClientTxContext(cmd)
 			if err != nil {
 				return err

diff --git a/x/cardchain/keeper/msg_server_set_card_rarity.go b/x/cardchain/keeper/msg_server_set_card_rarity.go
@@ -30,6 +30,11 @@ func (k msgServer) SetCardRarity(goCtx context.Context, msg *types.MsgSetCardRar
 	}
 
 	rarity := cardobject.Rarity(msg.Rarity)
+	err = rarity.ValidateType(cardobj)
+	if err != nil {
+		return nil, sdkerrors.Wrap(types.ErrCardobject, err.Error())
+	}
+
 	if cardobj.Action != nil {
 		cardobj.Action.Rarity = &rarity
 	} else if cardobj.Place != nil {