-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
123 openmatch transaction #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need a mechanism that secures that on a specific card a user can only give a vote once per epoch.
I would suggest we add an entry to cardchain user, that lists all cards already voted on in this epoch.
Then marius can also look this up in the gameclient and not show the voting button for those cards ingame.
With this solution we must not give voteRights if the id is already in the user and not allow votes even if voteRights are ignored?
return err | ||
} | ||
|
||
// TODO: Votes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this todo refer to the voteMatchCards above or is it a real TODO?
otherPlayerCards = otherPlayer.PlayedCards | ||
} else { | ||
otherPlayerCards = otherPlayer.Deck | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do I understand this correctly:
If the playedCards are used or the whole deck for voting rights, depends on who is first to report? the client or the server?
return nil | ||
} | ||
|
||
func (k Keeper) MatchWorker(ctx sdk.Context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit info why this is here and what it does would be good
No description provided.