Add symbol visibility

#164

CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Add `visibility` attribute to symbols.
+  - Allows to specify custom visibility, like `weak` or `local`, to each symbol.
+
 ## [1.25.1] - 2024-05-03
 
 ### Fixed

pyproject.toml

@@ -4,7 +4,7 @@
 [project]
 name = "spimdisasm"
 # Version should be synced with spimdisasm/__init__.py
-version = "1.25.1"
+version = "1.25.2.dev0"
 description = "MIPS disassembler"
 readme = "README.md"
 license = {file = "LICENSE"}

spimdisasm/__init__.py

@@ -5,8 +5,8 @@
 
 from __future__ import annotations
 
-__version_info__: tuple[int, int, int] = (1, 25, 1)
-__version__ = ".".join(map(str, __version_info__))# + ".dev0"
+__version_info__: tuple[int, int, int] = (1, 25, 2)
+__version__ = ".".join(map(str, __version_info__)) + ".dev0"
 __author__ = "Decompollaborate"
 
 from . import common as common

spimdisasm/common/ContextSymbols.py

@@ -212,6 +212,8 @@ class ContextSymbol:
 
     isMips1Double: bool = False
 
+    visibility: str = "global"
+
 
     @property
     def vram(self) -> int:
@@ -677,7 +679,7 @@ def getCsvHeader() -> str:
         output += "overlayCategory,unknownSegment,"
         output += "isGot,isGotGlobal,isGotLocal,gotIndex,accessedAsGpRel,"
         output += "firstLoAccess,isAutogeneratedPad,autoCreatedPadMainSymbol,isElfNotype,"
-        output += "isAutocreatedSymFromOtherSizedSym,isMips1Double"
+        output += "isAutocreatedSymFromOtherSizedSym,isMips1Double,visibility"
         return output
 
     def toCsv(self) -> str:
@@ -723,7 +725,7 @@ def toCsv(self) -> str:
         if self.autoCreatedPadMainSymbol is not None:
             autoCreatedPadMainSymbolName = self.autoCreatedPadMainSymbol.getName()
         output += f"{self.firstLoAccess},{self.isAutogeneratedPad()},{autoCreatedPadMainSymbolName},{self.isElfNotype},"
-        output += f"{self.isAutocreatedSymFromOtherSizedSym},{self.isMips1Double}"
+        output += f"{self.isAutocreatedSymFromOtherSizedSym},{self.isMips1Double},{self.visibility}"
         return output
 
 

spimdisasm/common/ElementBase.py

@@ -103,6 +103,8 @@ def getLabelFromSymbol(self, sym: ContextSymbol|None, symName: str|None) -> str:
             if label is None:
                 return ""
             label += f" {symName or sym.getName()}"
+            if sym.visibility != "global":
+                label += f", {sym.visibility}"
             if GlobalConfig.GLABEL_ASM_COUNT:
                 if self.index is not None:
                     label += f" # {self.index}"

spimdisasm/common/SymbolsSegment.py

@@ -608,3 +608,5 @@ def readSplatSymbolAddrs(self, filepath: Path) -> None:
                 allowBeReferenced = Utils.getMaybeBooleyFromMaybeStr(pairs.get("allow_be_referenced"))
                 if allowBeReferenced is not None:
                     contextSym.allowedToBeReferenced = allowBeReferenced
+
+                contextSym.visibility = pairs.get("visibility", contextSym.visibility)