Emacs/del outdated files #1188
Open
Emacs/del outdated files #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fblanqui
requested changes
Feb 1, 2025
| @@ -23,6 +23,14 @@ $(NAME)-$(VERSION).tar: $(SRC) | |||
| cp *.el "$(NAME)-$(VERSION)" | |||
| tar -cf "$(NAME)-$(VERSION)".tar "$(NAME)-$(VERSION)" | |||
|
|
|||
| .PHONY: lambdapi-mode-pkg.el | |||
There was a problem hiding this comment.
Could be useful if lambdapi-mode-pkg.el is accidentally altered between two generations. I can remove it if not really useful which would allow one to change the lambdapi-mode-pkg.el file manually before installation.
There was a problem hiding this comment.
I do not understand. PHONY means that this is a target that do not correspond to an actual file, doesn't it?
fblanqui
reviewed
Feb 5, 2025
editors/emacs/Makefile
Outdated
| @@ -47,3 +44,4 @@ check: dist | |||
| clean: | |||
| rm -f "$(NAME)-$(VERSION)".tar | |||
| rm -rf "$(NAME)-$(VERSION)" | |||
| rm -f lambdapi-mode-pkg.el | |||
There was a problem hiding this comment.
remark: you can do it with only one call to rm:
rm -rf "$(NAME)-$(VERSION)" "$(NAME)-$(VERSION)".tar lambdapi-mode-pkg.el
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is is originated by @tarsius
The information in -pkg.el did not agree with the information in .el. This pull-requests addresses that be removing the outdated -pkg.el.
However, since -pkg.el is necessary to install the package locally for debugging, an entry is added to the make file to generate it and include it to the
tarfile for local testing only.