Skip to content

Added Korean Translation #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added Korean Translation #420

wants to merge 2 commits into from

Conversation

acc0mplish
Copy link

📖 Description

  1. include a summary of the changes and the related issue, eg. Closes #XYZ
  2. Do not make a PR if you can't check all the boxes below

🛠️ Dev Branch Merge Checklist:

Documentation

  • If testing requires changes in the environment or deployment, please update the documentation (https://docs.defguard.net) first and attach the link to the documentation section in this pull request
  • I have commented on my code, particularly in hard-to-understand areas

Testing

  • I have performed manual tests manually and all changes work
  • New and existing unit tests pass locally with my changes

🏚️ Main Branch Merge Checklist:

Testing

  • I have merged my changes before to dev and the dev checklist is done
  • I have tested all functionalities on the dev instance and they work

Documentation

  • I have made corresponding changes to the user & admin documentation and added new features documentation with screenshots for users/admins

@teon teon requested review from t-aleksander and wojcik91 May 5, 2025 05:43
@t-aleksander t-aleksander changed the base branch from main to dev May 5, 2025 08:39
@t-aleksander t-aleksander changed the base branch from dev to main May 5, 2025 08:40
@t-aleksander
Copy link
Contributor

@acc0mplish Thanks for the contribution. Can you run npx eslint --fix .? There are some formatting issues with the translation file: https://github.com/DefGuard/client/actions/runs/14790909034/job/41634136121?pr=420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-aleksander t-aleksander Awaiting requested review from t-aleksander

@wojcik91 wojcik91 Awaiting requested review from wojcik91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acc0mplish @t-aleksander @acc0mplish-note