Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ruff to 0.8.1 #11350

Merged
merged 7 commits into from
Dec 20, 2024
Merged

bump ruff to 0.8.1 #11350

merged 7 commits into from
Dec 20, 2024

Conversation

manuel-sommer
Copy link
Contributor

@manuel-sommer manuel-sommer commented Nov 30, 2024

Fix for #11349

Copy link

dryrunsecurity bot commented Nov 30, 2024

DryRun Security Summary

The pull request introduces updates to various files in the DefectDojo application, focusing on dependency updates, authentication integrations, and test suite improvements, with potential security considerations around dynamic imports, input validation, and parsing external data.

Expand for full summary

Summary:

The code changes in this pull request cover a variety of updates across different files in the DefectDojo application. From an application security perspective, the changes do not appear to introduce any immediate security vulnerabilities, but there are a few areas that warrant further review and consideration:

  1. Dependency Updates: The update to the ruff library in the requirements-lint.txt file is a routine maintenance task that should be thoroughly tested to ensure it does not introduce any unintended issues or regressions.

  2. Dynamic Imports and Directory Traversal: The changes in the dojo/tools/factory.py file involve dynamic imports and iterating through directories, which could potentially lead to security issues if the input is not properly validated and sanitized.

  3. Identity Provider Integration: The changes in the dojo/pipeline.py file related to Azure AD and Google OAuth2 integration should be reviewed to ensure that the user creation and group management processes are secure and do not introduce any vulnerabilities.

  4. Input Validation and Parsing: The changes in the dojo/tools/crashtest_security/parser.py file involve parsing external data, which requires thorough input validation and error handling to prevent potential security issues.

  5. Test Suite Reliability: The changes in the tests/Import_scanner_test.py and unittests/test_factory.py files are focused on improving the reliability and portability of the test suite, which indirectly contributes to the overall security of the application.

Files Changed:

  1. requirements-lint.txt: The changes update the ruff library from version 0.8.0 to 0.8.1, which is a routine maintenance task.

  2. dojo/tools/factory.py: The changes involve dynamic imports and iterating through directories, which should be reviewed for potential security issues.

  3. dojo/pipeline.py: The changes are related to the integration of Azure AD and Google OAuth2 authentication, which should be reviewed to ensure the security of the user creation and group management processes.

  4. dojo/tools/crashtest_security/parser.py: The changes update the regular expression for vulnerability ID extraction and handle parsing of external data, which requires thorough input validation and error handling.

  5. tests/Import_scanner_test.py: The changes improve the reliability and portability of the test suite, which indirectly contributes to the overall security of the application.

  6. unittests/test_factory.py: The changes update the way the package directory is accessed and module names are retrieved, which also improves the reliability and portability of the test suite.

Code Analysis

We ran 9 analyzers against 6 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Configured Codepaths Analyzer 1 finding

Overall Riskiness

🔴 Risk threshold exceeded.

We've notified @mtesauro, @grendel513.

View PR in the DryRun Dashboard.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@manuel-sommer manuel-sommer changed the title bump ruff to 0.8.1 bump ruff to 0.8.3 Dec 15, 2024
@manuel-sommer manuel-sommer changed the title bump ruff to 0.8.3 bump ruff to 0.8.1 Dec 15, 2024
@manuel-sommer
Copy link
Contributor Author

Sorry for the delay, this should be fine now @mtesauro and @Maffooch

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit 460cd7c into DefectDojo:dev Dec 20, 2024
133 of 135 checks passed
@manuel-sommer manuel-sommer deleted the ruff_bump081 branch December 21, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants