-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Burp Scan to use Hashcode Dedupe #11419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Why file_path if this is DAST/endpoint? |
DryRun Security SummaryThe pull request enhances DefectDojo's vulnerability management capabilities by improving Burp findings deduplication through documentation updates and configuration changes in the settings file, including a new parser configuration and deduplication algorithm for Burp scans. Expand for full summarySummary: The changes in this pull request are primarily focused on improving the accuracy of the deduplication process for Burp findings in the DefectDojo vulnerability management tool. The key changes include the addition of a new section in the documentation explaining the "Hash Code changes" and the introduction of a custom deduplication configuration for the Burp parser. The documentation updates provide guidance on recalculating the hash code and deduplicating existing Burp findings, which is a useful feature for users upgrading to the new version. Additionally, the changes to the settings file, which include the addition of a new parser configuration and deduplication algorithm for the "Burp Scan" type, suggest that the project team has identified issues with the previous deduplication logic and has implemented improvements to address them. These changes are positive from an application security perspective, as they can help security teams better manage and prioritize the vulnerabilities identified by the Burp scanner, which is a common source of vulnerability information for many organizations. Files Changed:
Code AnalysisWe ran |
Excellent question. I was only paying attention to what items were available/listed in the scanner test files. I updated to remove file_path |
27128a9
to
3492784
Compare
[sc-9358]
Update Burp scan to use hashcode deduplication (versus legacy). Fields of relevance are title, file_path, severity, and vuln_id_from_tool.