Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/quasar vaults adaptor #1592

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

magiodev
Copy link

@magiodev magiodev commented Nov 7, 2024

No description provided.

@llamatester
Copy link

Error while running quasar-vaults adapter:

Test Suites: 1 failed, 1 total
Tests: 1 failed, 8 passed, 9 total
Snapshots: 0 total
Time: 0.284 s
Ran all test suites.

Nb of pools: 1
 

Sample pools:
┌─────────┬──────────────────────────────────────────────┬────────────┬──────────┬──────────┬──────────────────┬────────────────────┐
│ (index) │                     pool                     │   chain    │ project  │  symbol  │      tvlUsd      │        apy         │
├─────────┼──────────────────────────────────────────────┼────────────┼──────────┼──────────┼──────────────────┼────────────────────┤
│    0    │ '0x4f3Cc6359364004b245ad5bE36E6ad4e805dC961' │ 'Ethereum' │ 'mellow' │ 'wstETH' │ 2647508.76788085 │ 2.9734285714285713 │
└─────────┴──────────────────────────────────────────────┴────────────┴──────────┴──────────┴──────────────────┴────────────────────┘
}

@llamatester
Copy link

The quasar-vaults adapter exports pools:

Test Suites: 1 passed, 1 total
Tests: 9 passed, 9 total
Snapshots: 0 total
Time: 0.267 s
Ran all test suites.

Nb of pools: 1
 

Sample pools:
┌─────────┬──────────────────────────────────────────────┬────────────┬─────────────────┬──────────┬──────────────────┬───────┐
│ (index) │                     pool                     │   chain    │     project     │  symbol  │      tvlUsd      │  apy  │
├─────────┼──────────────────────────────────────────────┼────────────┼─────────────────┼──────────┼──────────────────┼───────┤
│    0    │ '0x4f3Cc6359364004b245ad5bE36E6ad4e805dC961' │ 'Ethereum' │ 'quasar-vaults' │ 'wstETH' │ 2675721.74382475 │ 2.977 │
└─────────┴──────────────────────────────────────────────┴────────────┴─────────────────┴──────────┴──────────────────┴───────┘

@slasher125
Copy link
Collaborator

gm,

  • symbol should be urLRT
  • poolMeta = mellow
  • pls confirm that the token can be swapped back to eg steth without lockups, otherwise that info needs to be put into poolMeta
  • data should be fetched from on chain calls using our sdk. at minimum to fetch the tvl values. you can use our price api for calculating the $ value

@magiodev
Copy link
Author

gm,

  • symbol should be urLRT
  • poolMeta = mellow
  • pls confirm that the token can be swapped back to eg steth without lockups, otherwise that info needs to be put into poolMeta
  • data should be fetched from on chain calls using our sdk. at minimum to fetch the tvl values. you can use our price api for calculating the $ value

Ok I will add the pooLMeta property. In case of lockup, could it be a free string like: mellow, N days lockup ?

Also, yes, the token can be redeemed, not really swapped. I mean, it could be swapped on Uniswap, but the protocol allows for redemption with a 1-7 days batched lockup period. I will add the information on the poolMeta accordingly.

From the Mellow docs: https://docs.mellow.finance/mellow-lrt-lst-primitive/user-tutorials/withdrawal-guide

Step 8: Lockup Period
After requesting withdrawal, you will not receive any points for the withdrawn LRT. The points earned are displayed in your dashboard. Withdrawals are processed by risk curators within 1-7 days in batches.

@slasher125
Copy link
Collaborator

yes pls add that info to poolMeta

@magiodev
Copy link
Author

yes pls add that info to poolMeta

thanks, may you also please point me to some prod code example about the price api? or any doc?

@slasher125
Copy link
Collaborator

yes pls add that info to poolMeta

thanks, may you also please point me to some prod code example about the price api? or any doc?

just search the repo for https://coins.llama.fi/prices/current/ there a ton of examples. docs here: https://defillama.com/docs/api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants