Block Enqueue race condition while waiting for latest block to be written #494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force block enqueue to fully wait for block to be available by moving to
< latestBlock
check.#487 RCA:
I was able to reproduce the issue from #487 in the following manner:
start-block = 1
end-block = -1
wait-for-chain = false
throttling = 0
rpc-workers = 4
I was able to reliably reproduce the state height loading error:
I think this is happening for the following reason: The Node is reporting LatestHeight from the Status RPC request before the height is fully available at the GetTxsEvent. This leads fast indexer configs to catch up to the chain really quickly and then requesting the Txs at the latest height way too fast.
This solution
This solution forces the block_enqueue to stay 1 block behind the value reported by latest height. This will prevent ever requesting transactions at a block height that is unavailable.
Closes #487