-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[itowns] Fix event map for View #70279
Conversation
@Methuselah96 Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 18 days — it is still unreviewed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 70279,
"author": "Methuselah96",
"headCommitOid": "f42f9458ed4bd2100d346a7704d03d7e5d39e8cb",
"mergeBaseOid": "6fadb7c9001318e86d5e52695c5a46746e3715bf",
"lastPushDate": "2024-08-13T01:18:10.000Z",
"lastActivityDate": "2024-08-13T01:18:10.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "itowns",
"kind": "edit",
"files": [
{
"path": "types/itowns/src/Core/View.d.ts",
"kind": "definition"
},
{
"path": "types/itowns/test/SourceFileFromFormat.ts",
"kind": "test"
},
{
"path": "types/itowns/test/SourceFileFromMethods.ts",
"kind": "test"
}
],
"owners": [
"desplandis",
"mgermerie"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 2285164665,
"ciResult": "pass"
} |
🔔 @Desplandis @mgermerie — please review this PR in the next few days. Be sure to explicitly select |
Re-ping @Desplandis, @mgermerie: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @Methuselah96. (Ping @Desplandis, @mgermerie.) |
Included as part of #70414 |
I'm working on improving the typing for event listeners in
@types/three
, however currently theView
class does not have its event map set up correctly. This PR corrects that so that we can move forward with the change in@types/three
.Please fill in this template.
pnpm test <package to test>
.If changing an existing definition:
package.json
.