Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[itowns] Fix event map for View #70279

Closed

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Aug 13, 2024

I'm working on improving the typing for event listeners in @types/three, however currently the View class does not have its event map set up correctly. This PR corrects that so that we can move forward with the change in @types/three.

Please fill in this template.

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 13, 2024

@Methuselah96 Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 18 days — it is still unreviewed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 70279,
  "author": "Methuselah96",
  "headCommitOid": "f42f9458ed4bd2100d346a7704d03d7e5d39e8cb",
  "mergeBaseOid": "6fadb7c9001318e86d5e52695c5a46746e3715bf",
  "lastPushDate": "2024-08-13T01:18:10.000Z",
  "lastActivityDate": "2024-08-13T01:18:10.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "itowns",
      "kind": "edit",
      "files": [
        {
          "path": "types/itowns/src/Core/View.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/itowns/test/SourceFileFromFormat.ts",
          "kind": "test"
        },
        {
          "path": "types/itowns/test/SourceFileFromMethods.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "desplandis",
        "mgermerie"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2285164665,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @Desplandis @mgermerie — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

Re-ping @Desplandis, @mgermerie:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Aug 24, 2024
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @Methuselah96.

(Ping @Desplandis, @mgermerie.)

@Methuselah96
Copy link
Contributor Author

Included as part of #70414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants