This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Don't treat mts/cts files as config files by using same check as dt-tools #488
Merged
jakebailey
merged 4 commits into
DefinitelyTyped:master
from
jakebailey:declaration-check
Feb 26, 2024
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,8 +15,9 @@ | |
"license": "MIT", | ||
"dependencies": { | ||
"@apollo/client": "latest", | ||
"@definitelytyped/old-header-parser": "npm:@definitelytyped/[email protected]", | ||
"@azure/functions": "^4.0.0-alpha.1", | ||
"@definitelytyped/old-header-parser": "npm:@definitelytyped/[email protected]", | ||
"@definitelytyped/utils": "^0.1.5", | ||
"@octokit/webhooks": "^9.5.1", | ||
"dayjs": "^1.10.3", | ||
"fast-json-patch": "^3.0.0-1", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ | |
"responseComments": [ | ||
{ | ||
"tag": "welcome", | ||
"status": "@andrewbranch Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 3 packages in this PR\n\n* `ansicolors` — [on npm](https://www.npmjs.com/package/ansicolors), [on unpkg](https://unpkg.com/browse/ansicolors@latest/)\n* `cardinal` (*new!*) — [on npm](https://www.npmjs.com/package/cardinal), [on unpkg](https://unpkg.com/browse/cardinal@latest/)\n - 1 added owner: ✎@andrewbranch\n - Config files to check:\n - [`cardinal/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67090/files/bb7d42f514b9f9cfca6b9a84dc99fac76ac35643#diff-9f471f9ba6ffa73024ae9aeb049dd98078364c565db83ee831e0498cbb678d67): edited\n* `marked-terminal` — [on npm](https://www.npmjs.com/package/marked-terminal), [on unpkg](https://unpkg.com/browse/marked-terminal@latest/)\n - Config files to check:\n - [`marked-terminal/index.d.cts`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67090/files/bb7d42f514b9f9cfca6b9a84dc99fac76ac35643#diff-5e4cfea677a3d26cff8f1c90abf32caa2f3c310beee12f6f84364821c728aef6): edited\n - [`marked-terminal/marked-terminal-tests.cts`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67090/files/bb7d42f514b9f9cfca6b9a84dc99fac76ac35643#diff-c57707862a9de137333983d3c0ee294d8a046f4f23a7e2557f7c4f4c77529dd7): edited\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=67090&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." | ||
"status": "@andrewbranch Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 3 packages in this PR\n\n* `ansicolors` — [on npm](https://www.npmjs.com/package/ansicolors), [on unpkg](https://unpkg.com/browse/ansicolors@latest/)\n* `cardinal` (*new!*) — [on npm](https://www.npmjs.com/package/cardinal), [on unpkg](https://unpkg.com/browse/cardinal@latest/)\n - 1 added owner: ✎@andrewbranch\n - Config files to check:\n - [`cardinal/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67090/files/bb7d42f514b9f9cfca6b9a84dc99fac76ac35643#diff-9f471f9ba6ffa73024ae9aeb049dd98078364c565db83ee831e0498cbb678d67): edited\n* `marked-terminal` — [on npm](https://www.npmjs.com/package/marked-terminal), [on unpkg](https://unpkg.com/browse/marked-terminal@latest/)\n - Config files to check:\n - [`marked-terminal/marked-terminal-tests.cts`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67090/files/bb7d42f514b9f9cfca6b9a84dc99fac76ac35643#diff-c57707862a9de137333983d3c0ee294d8a046f4f23a7e2557f7c4f4c77529dd7): edited\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=67090&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like we need to account for non-declaration test files too:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Aha, yes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's even more weird edge cases here... may do a little refactoring to fix them. |
||
}, | ||
{ | ||
"tag": "pinging-reviewers", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"relationship.js": 21 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"3f76a3a2d73f3fe577d32ca07c73c79016707328:types/relationship.js/package.json": "{\n \"private\": true,\n \"name\": \"@types/relationship.js\",\n \"version\": \"1.2.9999\",\n \"projects\": [\n \"https://passer-by.com/relationship/\"\n ],\n \"devDependencies\": {\n \"@types/relationship.js\": \"workspace:.\"\n },\n \"exports\": {\n \".\": {\n \"import\": \"./dist/relationship.min.d.mts\",\n \"require\": \"./dist/relationship.min.d.ts\",\n \"default\": \"./dist/relationship.min.d.ts\"\n },\n \"./mode\": {\n \"import\": \"./dist/relationship-mode.min.d.mts\",\n \"require\": \"./dist/relationship-mode.min.d.ts\",\n \"default\": \"./dist/relationship-mode.min.d.ts\"\n },\n \"./zh-HK\": {\n \"import\": \"./dist/relationship.min.d.mts\",\n \"require\": \"./dist/relationship.min.d.ts\",\n \"default\": \"./dist/relationship.min.d.ts\"\n },\n \"./zh-HK/mode\": {\n \"import\": \"./dist/relationship-mode.min.d.mts\",\n \"require\": \"./dist/relationship-mode.min.d.ts\",\n \"default\": \"./dist/relationship-mode.min.d.ts\"\n }\n },\n \"owners\": [\n {\n \"name\": \"whincwu\",\n \"githubUsername\": \"whinc\"\n }\n ]\n}\n", | ||
"dd92afb5a03c591944601de73a58bf49bb31e1dc:types/relationship.js/package.json": "{\n \"private\": true,\n \"name\": \"@types/relationship.js\",\n \"version\": \"1.2.9999\",\n \"projects\": [\n \"https://passer-by.com/relationship/\"\n ],\n \"devDependencies\": {\n \"@types/relationship.js\": \"workspace:.\"\n },\n \"owners\": [\n {\n \"name\": \"whincwu\",\n \"githubUsername\": \"whinc\"\n }\n ]\n}\n", | ||
"3f76a3a2d73f3fe577d32ca07c73c79016707328:types/relationship.js/tsconfig.json": "{\n \"compilerOptions\": {\n \"module\": \"node16\",\n \"lib\": [\n \"es6\"\n ],\n \"noImplicitAny\": true,\n \"noImplicitThis\": true,\n \"strictFunctionTypes\": true,\n \"strictNullChecks\": true,\n \"types\": [],\n \"noEmit\": true,\n \"forceConsistentCasingInFileNames\": true\n },\n \"files\": [\n \"index.d.ts\",\n \"dist/relationship.min.d.ts\",\n \"dist/relationship.min.d.mts\",\n \"dist/relationship-mode.min.d.ts\",\n \"dist/relationship-mode.min.d.mts\",\n \"relationship.js-tests.ts\"\n ]\n}\n", | ||
"dd92afb5a03c591944601de73a58bf49bb31e1dc:types/relationship.js/tsconfig.json": "{\n \"compilerOptions\": {\n \"module\": \"node16\",\n \"lib\": [\n \"es6\"\n ],\n \"noImplicitAny\": true,\n \"noImplicitThis\": true,\n \"strictFunctionTypes\": true,\n \"strictNullChecks\": true,\n \"types\": [],\n \"noEmit\": true,\n \"forceConsistentCasingInFileNames\": true\n },\n \"files\": [\n \"index.d.ts\",\n \"relationship.js-tests.ts\"\n ]\n}\n" | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds 1000 lines to the package-json; I can copy the glob out instead if that feels better. I doubt it will change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly better after refactoring dt-tools, but still pulling in stuff. Maybe that's okay.