Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major refactor to allow lazy sync iterators. #10

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Major refactor to allow lazy sync iterators. #10

merged 7 commits into from
Oct 12, 2023

Commits on Oct 8, 2023

  1. Major refactor to allow lazy sync iterators. 

    Fixes DelfinaCare#6.

Because the code was getting too unweildy and hard to follow, I
refactored the iterator proxies to their own classes in a separate file.
    @aebrahim
    aebrahim committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    ab7bd20 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Sync iterator listens outside the lock. 

    We yield only outside the lock to avoid potential deadlocks.
    @aebrahim
    aebrahim committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4da3c77 View commit details
    Browse the repository at this point in the history

  2. Make yield_results a public method. 

    Response to comment from DelfinaCare#10
    @aebrahim
    aebrahim committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9df9ecd View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Sync iterator wrapper has fewer possible states. 

    We use an enum to thoroughly document the possible states the yielding
function can be in, making the code a lot more readable IMHO!
    @aebrahim
    aebrahim committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    cf63c61 View commit details
    Browse the repository at this point in the history

  2. Add readability improvements per review.

    @aebrahim
    aebrahim committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    eb1aaf2 View commit details
    Browse the repository at this point in the history

  3. Make next_send execution local. 

    It is no longer set on the object, per discussion.
    @aebrahim
    aebrahim committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    1acccbc View commit details
    Browse the repository at this point in the history

  4. Address PR comments.

    @aebrahim
    aebrahim committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    f13164d View commit details
    Browse the repository at this point in the history