Handle exceptions and preserve function type. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aebrahim
force-pushed
the
polish
branch
2 times, most recently
from
6cc9511
to
c65517d
Compare
We add explicit exception handling, and the decorated function now will look like the original function to inspect (for example, an async function will have inspect.iscoroutinefunction evaluate to True. This makes significant progress towards DelfinaCare#12.
aebrahim
force-pushed
the
polish
branch
3 times, most recently
from
128d6db
to
6462ca7
Compare
floan
reviewed
Oct 12, 2023
:P Matt and I thought you'd find this interesting! He will review it too, don't worry. |
I do! Thanks for tagging me in the review! I'm sure I will have more follow ups the more I study coroutines 😁 |
It now re-uses the logic we have already implemented in _OnceBase to avoid re-inventing the wheel.
mattalbr
requested changes
Oct 12, 2023
Trying to release the lock during function execution was not worth the increased complexity, because subsequent calls would be blocked anyways on waiting for execution, so they may as well be blocked by the lock.
The new code is simple enough that we can have _callable directly create self-contained functions without it getting too long.
mattalbr
requested changes
Oct 12, 2023
Also, add documentation for iterator behavior.
This lets us ensure parallel function test calls execute in parallel.
mattalbr
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add explicit exception handling, and the decorated function now will look like the original function to inspect (for example, an async function will have inspect.iscoroutinefunction evaluate to True.