Add support for lazy async generators #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aebrahim
reviewed
Sep 29, 2023
| gen_3 = async_yielding_iterator() | ||
|
|
||
| self.assertEqual(counter.value, 0) | ||
| self.assertEqual(await anext(gen_1), 1) |
There was a problem hiding this comment.
It looks like anext was introduced in python 3.10.
Maybe we add a manaul backport?
if sys.version_info.minor < 10:
async def anext(iter): ...
|
It looks like mypy and black are unhappy |
|
FYI I updated the implementation to not block other generators while awaiting the next value, please give it a close look as it's definitely a bit more complicated! |
aebrahim
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5