Use '__IPYTHON__' flag

Delgan · Oct 15, 2023 · c33b17c · c33b17c
1 parent c443a85
commit c33b17c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/loguru/_colorama.py b/loguru/_colorama.py
@@ -1,3 +1,4 @@
+import builtins
 import os
 import sys
 
@@ -6,7 +7,7 @@ def should_colorize(stream):
     if stream is None:
         return False
 
-    if "IPython" in sys.modules and (stream is sys.stdout or stream is sys.stderr):
+    if getattr(builtins, "__IPYTHON__", False) and (stream is sys.stdout or stream is sys.stderr):
         try:
             import ipykernel
             import IPython

diff --git a/tests/test_colorama.py b/tests/test_colorama.py
@@ -1,3 +1,4 @@
+import builtins
 import os
 import sys
 from unittest.mock import MagicMock
@@ -172,6 +173,7 @@ class Shell:
     ipykernel.zmqshell.ZMQInteractiveShell = Shell
     ipykernel.iostream.OutStream = out_class
 
+    monkeypatch.setattr(builtins, "__IPYTHON__", True, raising=False)
     monkeypatch.setitem(sys.modules, "IPython", ipython)
     monkeypatch.setitem(sys.modules, "ipykernel", ipykernel)
     monkeypatch.setattr(sys, patched, stream, raising=False)
@@ -183,7 +185,7 @@ def test_jupyter_missing_lib(monkeypatch):
     # Missing ipykernal so jupyter block will err, should handle gracefully
     stream = StreamIsattyFalse()
 
-    monkeypatch.setitem(sys.modules, "IPython", MagicMock())
+    monkeypatch.setattr(builtins, "__IPYTHON__", True, raising=False)
     monkeypatch.setattr(sys, "stdout", stream)
 
     assert should_colorize(stream) is False