Fix "ValueError" using Loguru with Cython (when missing stack frame) #1240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #88.
Fix #680.
In Cython, calling
logger.info()
used to cause aValueError("call stack is not deep enough")
which happens because of Cython optimizations.As a workaround, this PR wraps the call into a
try / except
clause and generate "dummy" information if the frame failed to be retrieve:None
"<unknown>"
"<unknown>"
0
Not ideal, but certainly better than if Loguru didn't work at all.
Example of output: