Remove ruff config excludes #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delgan
reviewed
Sep 2, 2023
Delgan
reviewed
Sep 2, 2023
|
This is perfect, I'm really glad to see all these code smells addressed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #968
So I removed all the ignores of specific errors and the exclude of
loguru/__init__.pyiloguru/__init__.pyiI just addednoqa: N805(thanks for the detailed explanation @Delgan )1 / 0in the tests so I addednoqa: B018stacklevel=1which is the default value but bugbear wants this to be explicit. So no change of behavior expected.tests/test_filesink_retention.pyso I removed the duplicate.fromclause because the code was reraising an exception without it. That one needs your review @Delgan!