Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity 6 #236

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6453780
Upgrade to Unity 6
Delt06 Apr 15, 2024
7d863b5
Change package Unity version
Delt06 Apr 15, 2024
1d97782
Upgrade package dependencies
Delt06 Apr 15, 2024
c8febac
Fix warning in ToonRenderPipelineAsset.cs
Delt06 Apr 15, 2024
c6ffc34
Fix deprecated warning in LightRotation
Delt06 Apr 15, 2024
a253492
Update OpenXR Package Settings.asset
Delt06 Apr 15, 2024
ccd2380
Upgrade format usage in ToonCameraRenderer.cs
Delt06 Apr 15, 2024
3558795
Upgrade skybox draw API
Delt06 Apr 15, 2024
9fcfa5b
Upgrade format usage in ToonShadowMapFormatUtils.cs
Delt06 Apr 15, 2024
3e8961f
Fix GLES2 deprecation warning in ToonGraphicsApi.cs
Delt06 Apr 15, 2024
eee3197
Upgrade the creation of directional ShadowDrawingSettings
Delt06 Apr 15, 2024
4a4f825
Upgrade to renderer lists in ToonDepthPrePass.cs and ToonMotionVector…
Delt06 Apr 15, 2024
a415571
Upgrade DrawUnsupportedShaders in ToonCameraRenderer.Editor.cs
Delt06 Apr 15, 2024
7f25715
Upgrade ToonInvertedHullOutline to renderer lists
Delt06 Apr 15, 2024
456283a
Migrate to renderer lists in ToonCameraRenderer.DrawGeometry
Delt06 Apr 16, 2024
b8d9baa
Remove deprecated VS Code package
Delt06 Apr 17, 2024
60e7d94
Merge branch 'master' into unity-6
Delt06 Apr 18, 2024
d384599
Merge branch 'master' into unity-6
Delt06 Apr 23, 2024
6dbfd62
BakedBlobShadowImporter.cs: force linear format
Delt06 Apr 23, 2024
d2fbe45
CustomSceneRenderPipeline.cs: GraphicsSettings.renderPipelineAsset ->…
Delt06 Apr 23, 2024
825de0e
Upgrade to Unity 6000.0.0b16
Delt06 Apr 23, 2024
72a130d
Move directional shadows to renderer lists
Delt06 Apr 23, 2024
5728e33
Move additional shadows to renderer lists
Delt06 Apr 23, 2024
62873c6
Merge branch 'refs/heads/master' into unity-6
Delt06 Jul 8, 2024
b18fe4d
Don't assert when ComputeDirectionalShadowMatricesAndCullingPrimitive…
Delt06 Jul 8, 2024
6c95c38
Implement proper ZClip for shadow maps
Delt06 Jul 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't assert when ComputeDirectionalShadowMatricesAndCullingPrimitive…
…s returns false
Delt06 committed Jul 8, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit b18fe4dd1a37506b1bb58ab75cb4d151e38c1db2
Original file line number Diff line number Diff line change
@@ -45,11 +45,10 @@ public static void AddDirectionLightShadowInfo(ref Data data, int visibleLightIn
{
LightSliceInfo lightSliceInfo;

bool computeSuccess = data.CullingResults.ComputeDirectionalShadowMatricesAndCullingPrimitives(
data.CullingResults.ComputeDirectionalShadowMatricesAndCullingPrimitives(
visibleLightIndex, i, cascadeCount, ratios, shadowResolution, nearPlaneOffset,
out lightSliceInfo.ViewMatrix, out lightSliceInfo.ProjectionMatrix, out ShadowSplitData splitData
);
Assert.IsTrue(computeSuccess);

data.ShadowCastersCullingInfos.splitBuffer[data.CurrentShadowSplitBufferOffset] = splitData;
++data.CurrentShadowSplitBufferOffset;