Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Security dogs now have vulpkanin vocal emotes #1176

Merged
merged 4 commits into from
May 9, 2024

Conversation

Remuchi
Copy link
Contributor

@Remuchi Remuchi commented May 8, 2024

About the PR

I've added vulpkanin emotes for doggos. Now they can bark, howl etc.
Reorganized inventory template so the UI is not longer a buggy mess and all slots are now displayed correctly.

Why / Balance

Emotes and UI are pure cosmetic changes.

With ID slot comes some questions - I've seen that it was previously deleted.
I, personally, think that secdogs - especially Laika - should have the ID slot, but it should be empty at the start. So if the security wants they can make an ID for Laika. She can't open doors as Shiva can, so having ID card can help with it.
Without ID card Laika just stuck at bumping security doors until someone from security opens it for her.

Media

New UI:
image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: Security dogs (such as Laika) now have vulpkanin vocal emotes. Howl!

@github-actions github-actions bot added the Changes: YML Changes any yml files label May 8, 2024
@Bonktrauma
Copy link
Contributor

Security dogs have received an ID slot before, and it was removed

@Bonktrauma
Copy link
Contributor

Security dogs have received an ID slot before, and it was removed

I'm like, 90% sure of this

@Bonktrauma
Copy link
Contributor

#882

@deltanedas
Copy link
Member

deltanedas commented May 8, 2024

emotes should be separate pr since that seems drama free, dont think anyone will object to it

@Remuchi
Copy link
Contributor Author

Remuchi commented May 8, 2024

I can always just revert the ID slot commit, no problems

@DangerRevolution
Copy link
Contributor

Laika ID should be separate PR because it's more controversial than emotes

@therealDLondon
Copy link
Member

Laika and the sec dogs lost the ID slot for a reason, and they shouldnt be added back without an admin discussion

Copy link
Contributor

@NullWanderer NullWanderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like London said, ID cards aren't allowed to be added back in right now. The emote changes are fine tho

@Remuchi
Copy link
Contributor Author

Remuchi commented May 8, 2024

I suggest then to discuss bringing back sechud glasses for her too. Since all security starts with them again, and it was the reason to remove them from Laika iirc

@Remuchi Remuchi changed the title [Tweak] Security doggos tweaks [Feat] Security dogs now have vulpkanin vocal emotes May 8, 2024
@A-z-z-y A-z-z-y requested a review from NullWanderer May 8, 2024 19:27
@deltanedas deltanedas merged commit b993a04 into DeltaV-Station:master May 9, 2024
12 checks passed
@deltanedas
Copy link
Member

@BARKS bind players keep winning

@WarMechanic
Copy link
Contributor

Awesome!

@Remuchi Remuchi deleted the secdogs-tweaks branch May 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants