Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change military boot whitelist tag #1794

Merged
2 commits merged into from
Sep 21, 2024

Conversation

TadJohnson00
Copy link
Contributor

About the PR

Adds a "ConcealCarry" tag.
Replaces the "Sidearm" whitelist tag for military boots with a "ConcealCarry" tag.

Why / Balance

Lays groundwork for future separation of concealed carry and fullsize pistols wrt stowing in combat boots, clothing, etc.

Technical details

n/a

Media

n/a

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

Doesn't change anything in-game yet

@github-actions github-actions bot added the Changes: YML Changes any yml files label Sep 11, 2024
@ghost ghost self-requested a review as a code owner September 21, 2024 06:31
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, doesn't have any conflicts, properly comments on upstream files, the tags don't choke, merging.

@ghost ghost merged commit 3fd5287 into DeltaV-Station:master Sep 21, 2024
12 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant