Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mass sleep #1816

Merged
1 commit merged into from
Sep 14, 2024
Merged

fix mass sleep #1816

1 commit merged into from
Sep 14, 2024

Conversation

TadJohnson00
Copy link
Contributor

...because Milon fucked it up

About the PR

Change forced sleep duration from 30s to 5s

Why / Balance

30s of honk shoo despite taking damage? Muy bien balance

Technical details

n/a

Media

n/a

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

n/a
Changelog

🆑

  • tweak: Mass sleep duration reduced from 30s to 5s.

...because Milon fucked it up
@TadJohnson00 TadJohnson00 requested a review from a team as a code owner September 12, 2024 06:54
@deltanedas
Copy link
Member

you can just wake up after 5 seconds because theres a 1 second cooldown on the wake up action

@TadJohnson00
Copy link
Contributor Author

you can just wake up after 5 seconds because theres a 1 second cooldown on the wake up action

Erm the button doesn't work

@deltanedas
Copy link
Member

when forcedsleep is active, yes

@TadJohnson00
Copy link
Contributor Author

And the forced sleep seems to be active for the whole duration of 30s

@deltanedas
Copy link
Member

because if its not forced they can immediately wake up since the action has no delay

@TadJohnson00
Copy link
Contributor Author

Hence the change from 30s to 5s

@Yousifb26
Copy link
Contributor

5 seconds feels short, I feel like 10-15 seconds would be better but that’s my opinion

@UnicornOnLSD
Copy link
Contributor

5 seconds feels short, I feel like 10-15 seconds would be better but that’s my opinion

Considering it's an instant click concealed way to stun someone, 5 seconds is already plenty, hell that is easier to pull off than a slip and cuff and the victim won't be able to do anything for 5 seconds.

TL:DR, nah it's fine, 5 seconds is still PLENTY

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single number change, sure, let's see how it goes?

@ghost ghost merged commit 3fd3a58 into DeltaV-Station:master Sep 14, 2024
13 checks passed
@TadJohnson00 TadJohnson00 deleted the nerfmasssleep branch September 28, 2024 10:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants