Limit "Die a glorious death" objective to one traitor per round. #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Status: Needs Review
Changes: YML
This comment was marked as outdated.
This comment was marked as outdated.
When I tested it only let one person have the objective so I think its OK? Looking at the code, it also appears to make sense and should work like I thought. Also your the one who wrote it so if it doesn't work I blame you 🧌 |
|
escape characters do not appear to work on github so that emoji is not correct 😭 |
|
|
TadJohnson00
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
See the title!
Why / Balance
A lot of shifts (Especially with a lot of traitors) can end up having three or four people with the objective which ends up very chaotic and not fun. Limiting it to one per round still allows the objective to come up, just not dominate the round!
Changelog
🆑 Beck Thompson