Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make random sentience a glimmer event + fix glimmer events not existing #1834

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

deltanedas
Copy link
Member

About the PR

title, it burns 20-60 glimmer when glimmer is between 300 and 600.

also adds a scheduler for glimmer events so they can run, nobody reported no glimmer events in the past month

Why / Balance

glimmer working is good
atm the scheduler runs a glimmer event every 5-15 minutes

Technical details

  • removed nyano GlimmerRandomSentience code and event, new one just uses upstream's component
  • replaced revenant spawn with GlimmerMobRule, and added MaxSpawns so no 50 revenants
  • added GlimmerEventScheduler which is added to all presets besides sandbox

Requirements

Breaking changes

removed GlimmerRandomSentienceRule and GlimmerRevenantSpawnRule

Changelog
🆑

  • tweak: Made the random sentience event a glimmer event.
  • fix: Fixed glimmer events never running.

@deltanedas deltanedas requested a review from a team September 16, 2024 16:39
@deltanedas deltanedas requested review from a team as code owners September 16, 2024 16:39
@github-actions github-actions bot added Status: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files labels Sep 16, 2024
Signed-off-by: deltanedas <[email protected]>
Copy link
Contributor

@TadJohnson00 TadJohnson00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

direction-approved changes

@deltanedas deltanedas merged commit d98fbbe into DeltaV-Station:master Sep 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants