Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port pitbulls from legacy #1835

Closed
wants to merge 9 commits into from

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Sep 16, 2024

About the PR

mostly the same as they were with some key changes:

  • vent pitbulls have their own event instead of being tacked onto mouse migration
  • if you fail to pet a pitbull it just retaliates instead of permanently making you KOS, meaning youd have to always kill the pitbull once someone failed to pet it. now they can run away and they will forget
  • internally named Pitbull not Pibble
  • made walter the base for pitbull to reduce copy paste and removing 90% of duplicate components from walter in an upstream file
  • cargo order uses pitbull sprite instead of walter, false advertisement

Why / Balance

poor old baby wouldnt hurt a fly
baby:

Technical details

add HostileOnInteractFail that uses space-wizards/space-station-14#32216

Media

:trollface:

Requirements

Breaking changes

no

Changelog
🆑

  • add: Pitbulls are back, couriers beware of what comes from the vents....

@deltanedas deltanedas requested a review from a team September 16, 2024 18:07
@github-actions github-actions bot added Status: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi labels Sep 16, 2024
Copy link
Contributor

github-actions bot commented Sep 16, 2024

RSI Diff Bot; head commit 129dca6 merging into d27668e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Nyanotrasen/Mobs/Pets/pitbull.rsi

State Old New Status
alive Added
dead Added

Resources/Textures/Nyanotrasen/Mobs/Pets/ventbull.rsi

State Old New Status
alive Added
dead Added

Edit: diff updated after 129dca6

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the current yaml, seems fine, but I noticed one thing. Also I can see TJ having opinions on this

@ghost
Copy link

ghost commented Sep 17, 2024

pro

@ghost
Copy link

ghost commented Sep 17, 2024

Still needs Game Director and general maint approval

@deltanedas
Copy link
Member Author

and needs upstream pr :trollface:

@VileSloth
Copy link

If these are going to be added, I suggest that they do not attack anyone for no reason, IE attacking a courier just because they are wearing courier clothes, as it perpetuates a stereotype that leads to animal abuse.

@TadJohnson00
Copy link
Contributor

Hey, so, direction here.
We'd appreciate it if this wasn't brought back from Nyano. Sorry for the inconvenience

@deltanedas
Copy link
Member Author

couriers on top

@deltanedas deltanedas closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants